Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18444
to look at the new patch set (#4).
Change subject: IMPALA-11257: Fix CMake warnings for module names and
cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
topmost CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M bin/bootstrap_build.sh
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
18 files changed, 20 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/4
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
