Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18433 )
Change subject: IMPALA-11141: Use exact data types in IN-list filter ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18433/2/be/src/util/in-list-filter.cc File be/src/util/in-list-filter.cc: http://gerrit.cloudera.org:8080/#/c/18433/2/be/src/util/in-list-filter.cc@65 PS2, Line 65: default: > Sure. But to the question whether to support float/double in InList filter, I think min/max filters make more sense since they can be used in non-equal joins. IN-list filters can only be generated by equal joins. Maybe DECIMAL is better than float/double if users do want to join on decimal columns. Found a related discussion on SQLServer: https://social.msdn.microsoft.com/forums/sqlserver/en-US/9539c78e-3e63-4faf-b9fb-5163ce0980b5/joining-on-columns-with-float-data-types -- To view, visit http://gerrit.cloudera.org:8080/18433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id434a542b2ced64efa3bfc974cb565b94a4193e9 Gerrit-Change-Number: 18433 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 26 Apr 2022 01:07:18 +0000 Gerrit-HasComments: Yes
