Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18439 )
Change subject: IMPALA-11263: Coordinator hang when cancelling a query ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18439/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/18439/3/be/src/runtime/coordinator-backend-state.cc@204 PS3, Line 204: while > nit. Use of 'IF' here probably is better for understanding the code. That's a really good point. I missed that this while loop is now not really a while loop. We could also add a DCHECK after the exec_done_cv_.Wait(*l) line. -- To view, visit http://gerrit.cloudera.org:8080/18439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I915511afe2df3017cbbf37f6aff3c5ff7f5473be Gerrit-Change-Number: 18439 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 27 Apr 2022 16:28:28 +0000 Gerrit-HasComments: Yes
