Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18415 )
Change subject: IMPALA-10057: Fix log spew by using jars in the classpath ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18415/5/bin/validate-java-pom-versions.sh File bin/validate-java-pom-versions.sh: http://gerrit.cloudera.org:8080/#/c/18415/5/bin/validate-java-pom-versions.sh@34 PS5, Line 34: declare -a POM_XML_FILES=( > Could we use `git ls-files '**/pom.xml'` to enumerate all pom.xml in the re Good point, it's better to autodetect this. For Apache Impala releases, we produce a source tarball without git information. We do want the build to work for that source tarball. I changed this to autodetect pom.xml files via "find ${IMPALA_HOME} -name pom.xml". If this is a git checkout, it ignores pom.xml files that are not known to git. -- To view, visit http://gerrit.cloudera.org:8080/18415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id35544e446c5bf283c322d3fe2e7ad475cfa12eb Gerrit-Change-Number: 18415 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 07 May 2022 00:53:18 +0000 Gerrit-HasComments: Yes
