Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18504 )
Change subject: IMPALA-11256: Push-down IS_NULL predicate to iceberg ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Looks good to me nit: some variety could be nice to the number of NULLs, only "cast(col_str as TIMESTAMP) is null" matches for multiple rows and it's not a push down. http://gerrit.cloudera.org:8080/#/c/18504/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18504/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-11256 This should be IMPALA-11283 I think -- To view, visit http://gerrit.cloudera.org:8080/18504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c3608af67b552bebc55dcc5526f61f5439967bf Gerrit-Change-Number: 18504 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 09 May 2022 14:17:49 +0000 Gerrit-HasComments: Yes
