Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18505 )
Change subject: IMPALA-10199: Add a toolchain build for Ubuntu 20 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18505/1/source/gcc/gcc-7.5.0-patches/0001-PATCH-glibc-2.31-libsanitizer.patch File source/gcc/gcc-7.5.0-patches/0001-PATCH-glibc-2.31-libsanitizer.patch: http://gerrit.cloudera.org:8080/#/c/18505/1/source/gcc/gcc-7.5.0-patches/0001-PATCH-glibc-2.31-libsanitizer.patch@23 PS1, Line 23: -#elif defined(__mips__) || defined(__aarch64__) || defined(__s390x__) > Why remove the architecture checks? Are they no longer relevant? The reason this is removed is that the #else condition (which extends beyond the edge of this diff) is now the same as what these architectures used before. https://github.com/gcc-mirror/gcc/blob/master/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h#L219 -- To view, visit http://gerrit.cloudera.org:8080/18505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3bb716448173d718a675b45bddd34228fdfac6d Gerrit-Change-Number: 18505 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 10 May 2022 02:57:15 +0000 Gerrit-HasComments: Yes
