Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18513 )
Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata ...................................................................... Patch Set 3: (1 comment) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/18513/3/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/18513/3/be/src/exec/parquet/hdfs-parquet-table-writer.cc@892 PS3, Line 892: ++num_values_; We already keep track the number of values in the column writer. I think it's better to only keep track it at one place, as it is simpler and less error-prone. Probably you could move the num value tracking to ColumnStats only, so the col writer wouldn't track it on its own. Or only track num values here, and pass col_writer->num_values() to GetIcebergStats(). -- To view, visit http://gerrit.cloudera.org:8080/18513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b7afab8be197118e573fda1a381fa08e4c8c9c0 Gerrit-Change-Number: 18513 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 May 2022 13:35:55 +0000 Gerrit-HasComments: Yes
