Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17640 )
Change subject: IMPALA-10436: Require lower privilege for external Kudu table creation ...................................................................... Patch Set 5: (4 comments) Some high level comments, will dig into the details later. http://gerrit.cloudera.org:8080/#/c/17640/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17640/5//COMMIT_MSG@13 PS5, Line 13: RWSTORAGE Can you add the Jira id of this new Ranger feature here and also link it to the Impala Jira? http://gerrit.cloudera.org:8080/#/c/17640/5//COMMIT_MSG@29 PS5, Line 29: 'kudu://localhost/impala::tpch_kudu.nation' Do we only provide privileges for full paths, or prefixes can be also used like 'kudu://localhost/impala::tpch_kudu.*'? With the full path we can only create table based on a single Kudu table, right? http://gerrit.cloudera.org:8080/#/c/17640/5//COMMIT_MSG@41 PS5, Line 41: On the other hand, after this patch we still require a user to have the Can you add a simple example for the two kind of external Kudu table creation? http://gerrit.cloudera.org:8080/#/c/17640/5/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/17640/5/common/thrift/CatalogObjects.thrift@745 PS5, Line 745: 13: optional string storage_type Can you add comments for the new members? -- To view, visit http://gerrit.cloudera.org:8080/17640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7936e1d8c48696169f7ad7ad92abe44a26eea3c4 Gerrit-Change-Number: 17640 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 11 May 2022 16:27:55 +0000 Gerrit-HasComments: Yes
