Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18507 )
Change subject: refactor DumpCallback to make it more readable ...................................................................... Patch Set 1: I'll fold it into the other change then. I think I'll put back `/ sizeof(char)`, since while it's not needed it is descriptive. -- To view, visit http://gerrit.cloudera.org:8080/18507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71c99f77c1c1af43b80bae88f6ff4289934dcdc3 Gerrit-Change-Number: 18507 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 11 May 2022 20:27:42 +0000 Gerrit-HasComments: No
