Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18508 )
Change subject: IMPALA-11275: log thread info during minidump ...................................................................... Patch Set 3: (2 comments) Addressed comments and added tests. http://gerrit.cloudera.org:8080/#/c/18508/1/be/src/util/minidump.cc File be/src/util/minidump.cc: http://gerrit.cloudera.org:8080/#/c/18508/1/be/src/util/minidump.cc@69 PS1, Line 69: static void write_dump_threadinfo(int fd, ThreadDebugInfo* thread_info) { : constexpr char thread_msg[] = "Minidump in thread "; : // pid_t is signed, but valid process IDs must always be positive. : const int64_t thread_id = thread_info->GetSystemThreadId(); : // 20 characters needed for UINT64_MAX. : > For this function, it would be useful to be able to unit test the conversio Done http://gerrit.cloudera.org:8080/#/c/18508/1/be/src/util/minidump.cc@79 PS1, Line 79: cons > Minor style point: Done -- To view, visit http://gerrit.cloudera.org:8080/18508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea2bdf10db29a0f8ccbe5e767b708781d42a9b8a Gerrit-Change-Number: 18508 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 11 May 2022 23:14:49 +0000 Gerrit-HasComments: Yes
