Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 )
Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() ...................................................................... Patch Set 14: (2 comments) I double the tests and find a question we need to address. http://gerrit.cloudera.org:8080/#/c/18413/14/testdata/workloads/functional-query/queries/QueryTest/aggregation.test File testdata/workloads/functional-query/queries/QueryTest/aggregation.test: http://gerrit.cloudera.org:8080/#/c/18413/14/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@1492 PS14, Line 1492: 1.01233222875e-08 Hive returns NULL in this case. I think the reason is https://issues.apache.org/jira/browse/HIVE-16178: If N * SUMX2 equals SUMX * SUMX , then the result is the null value. If N * SUMY2 equals SUMY * SUMY , then the result is the null value. The commit is https://github.com/apache/hive/commit/d97e4874dc0e09c535e8cb908f6b17698e49a5d6 Could you check if indeed N * SUMY2 equals SUMY * SUMY in this case, or it's a precision issue in Hive? http://gerrit.cloudera.org:8080/#/c/18413/14/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@1558 PS14, Line 1558: ==== For tests on window functions, can we also copy Hive's test? https://github.com/apache/hive/blob/3b3da9ed7f3813bae3e959670df55682fea648d3/ql/src/test/results/clientpositive/llap/windowing.q.out#L853-L890 -- To view, visit http://gerrit.cloudera.org:8080/18413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ad627c953ba24d9cde2d5549bdd0d27a9c0d06 Gerrit-Change-Number: 18413 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 16 May 2022 01:36:07 +0000 Gerrit-HasComments: Yes
