Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18543 )
Change subject: IMPALA-11301: Fix extreme != selectivity for NDV=1 ...................................................................... Patch Set 4: > Latest changes lgtm. Only other thought was about the unit test > itself. It relies on the current behavior of row_number ndv > estimate. Were you thinking of adding any other test against a > table whose column had ndv=1 ? Add a test with a table with a column of ndv 1. Originally I thought that there are no such test tables and didn't want to create one, but the jenkins job has pointed me to tpcds tables. -- To view, visit http://gerrit.cloudera.org:8080/18543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b5334a8d7d6ca46a450ff98ae03e5269faaa3c6 Gerrit-Change-Number: 18543 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 May 2022 17:34:04 +0000 Gerrit-HasComments: No
