Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18536 )
Change subject: IMPALA-10465: Use IGNORE variant of Kudu write operations ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18536/5/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/18536/5/be/src/exec/kudu-table-sink.cc@360 PS5, Line 360: if (is_transactional_) { : // Return general status error to abort transaction. : return Status("Kudu reported write operation errors during transaction."); : } > Right, but in line 382 there could be no errors due to INSERT_IGNORE opera Ah, probably I see what you mean -- in the absence of XXX_IGNORE ops there would be an error and the transaction would be aborted at line 382. >From the perspective of an end-user, I'd appreciate if there was a choice what >to do here, frankly. Does it make sense to add an extra flag to control this >behavior? I.e. whether or not to abort a transaction when using INSERT_IGNORE >operations when a duplicate key was reported? By default it might keep the >'legacy' behavior of aborting the transaction in such a case, but there would >be an option to avoid doing so, if the flag explicitly set to behave otherwise. -- To view, visit http://gerrit.cloudera.org:8080/18536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8da7c41d61b0888378b390b8b643238433eb3b52 Gerrit-Change-Number: 18536 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 21 May 2022 03:14:55 +0000 Gerrit-HasComments: Yes
