Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 )
Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18537/2/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/18537/2/tests/custom_cluster/test_local_catalog.py@276 PS2, Line 276: print 'Attempt', attempt, 'client', str(client) > Is this intentional, or just debug code? I add them intentionally so it's easy to know how many attempts have been tried in a thread. Before this patch, the timeout is 30s so neither thread can try 200 attempts. It took me a while to realize this. So I think adding this will be helpful. Also it's not that verbose since we already log the query string for each attempt. http://gerrit.cloudera.org:8080/#/c/18537/2/tests/custom_cluster/test_local_catalog.py@292 PS2, Line 292: t.join(600) > Will we usually need this much time? 10 mins looks a lot, especially if the It's just a safe guard in case the threads hang. Normally they will exit after trying at most 200 attempts, and usually they don't need that much attempts. In my tests, the whole run of TestLocalCatalogRetries took 1 min 27 sec. Here are the time of the 4 tests: Test name Duration Status test_fetch_metadata_retry 13 sec Passed test_invalidation_races 26 sec Passed test_replan_limit 34 sec Passed test_replan_on_stale_metadata 12 sec Passed -- To view, visit http://gerrit.cloudera.org:8080/18537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5bdca7402039f1f24b7bf19595c2541fa32d0ad Gerrit-Change-Number: 18537 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 23 May 2022 08:54:29 +0000 Gerrit-HasComments: Yes
