Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18561 )
Change subject: IMPALA-11281: Load table metadata for ResetMetadataStmt ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18561/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java File fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java: http://gerrit.cloudera.org:8080/#/c/18561/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java@142 PS1, Line 142: : Preconditions.checkNotNull(tableName_); : String dbName = analyzer.getTargetDbName(tableName_ > Thanks Quanlong! I am answering my question above. I think if we load the table metadata in StmtMetadataLoader#collectTableCandidates() for ResetMetadataStmt when Ranger table masking is supported as in patchset 2, then collectTableRefs() will not be called. -- To view, visit http://gerrit.cloudera.org:8080/18561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c90b413974223886661697f11844d99a68fdebf Gerrit-Change-Number: 18561 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 25 May 2022 03:45:37 +0000 Gerrit-HasComments: Yes
