Laszlo Gaal (Cloudera) has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18556 )

Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 
fixes
......................................................................


Patch Set 2: Code-Review+2

LGTM.
Makes me wonder though if string I/O vs Unicode at the various boundaries of 
impala-shell deserves a general review with the switch to Python 3.
This would of course be an activity independent of the current ticket.


--
To view, visit http://gerrit.cloudera.org:8080/18556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie58380a17d7e011f4ce96b27d34717509a0b80a6
Gerrit-Change-Number: 18556
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 25 May 2022 18:03:24 +0000
Gerrit-HasComments: No

Reply via email to