Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )
Change subject: IMPALA-11233: Unset all query option ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h@344 PS4, Line 344: /// Reset all query options to its default value if they are not equal to default value. > Could you please write some comment for this functions as you see for the o Done http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1301 PS4, Line 1301: set_ > nit: I see at other functions that they call this param as 'set_query_optio Done http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1307 PS4, Line 1307: query_options->NAME = defaults.NAME; \ > is there a case when defaults.__isset.NAME is true? Can't we simply set que Done http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java File fe/src/main/java/org/apache/impala/analysis/SetStmt.java: http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java@55 PS4, Line 55: public SetStmt(String key, String value, boolean isSetAll, boolean isUnsetAll) { > At the callsite of this when you see "new SetStmt(true)" it's not really se Done -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Comment-Date: Fri, 27 May 2022 09:53:47 +0000 Gerrit-HasComments: Yes
