Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18578 )
Change subject: [tools] Fix building shell_pypi_package ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18578/2/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18578/2/CMakeLists.txt@466 PS2, Line 466: COMMAND env "DIST_DIR=${CMAKE_SOURCE_DIR}/shell/dist" "CLEAN_DIST=true" "${CMAKE_SOURCE_DIR}/shell/packaging/make_python_package.sh" It also turns out CLEAN_DIST is never checked, and we could update the default for DIST_DIR to point to this location. -- To view, visit http://gerrit.cloudera.org:8080/18578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60ffac3edf1a6027afa4ca46ab6dadfc6bfc660a Gerrit-Change-Number: 18578 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 02 Jun 2022 22:02:23 +0000 Gerrit-HasComments: Yes
