Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18579 )
Change subject: IMPALA-11323: Don't evaluate constants-only inferred predicates ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Thanks for making the changes. Code changes LGTM. One other thought was about the planner test (similar to what was added in https://gerrit.cloudera.org/c/16917/4/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test). However, considering that you have the e2e test coverage, I am good with it. http://gerrit.cloudera.org:8080/#/c/18579/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18579/3//COMMIT_MSG@9 PS3, Line 9: IMPALA-101822 fixed the problem of creating inferred predicates when Still not the right jira id :) -- To view, visit http://gerrit.cloudera.org:8080/18579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1cd4559dda406d2d38703ed594b70b41ed336fd Gerrit-Change-Number: 18579 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 03 Jun 2022 19:23:49 +0000 Gerrit-HasComments: Yes
