Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18588 )
Change subject: IMPALA-8373: Test impala-shell with python3 ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/18588/11/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/18588/11/tests/shell/util.py@355 PS11, Line 355: os.path.join(IMPALA_HOME, 'shell/build/py3/bin/impala-shell') > Adding so many dimensions makes these tests take awhile, ~20 minutes on my Two tools at our disposal: 1. We can add constraints and drop specific test configurations that might be redundant. 2. We can move some test configurations to the "exhaustive" tests. Both are limiting what we would find via the usual precommit. Our dimensions are: 3 protocols (beeswax, hs2, hs2-http) 3 shells (non-pypi, pypi py2, pypi py3) strict_hs2_protocol=True,False For core, we could restrict strict_hs2_protocol=True to the non-pypi shell. Beeswax is deprecated, and we could restrict it to the non-pypi + pypi py3. For exhaustive, we could run everything. Here's an example of a test case that adds constraints for core: https://github.com/apache/impala/blob/master/tests/query_test/test_join_queries.py#L61-L63 -- To view, visit http://gerrit.cloudera.org:8080/18588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e123aecd53a7ded44a7da7eb8c8b853cebbfc56 Gerrit-Change-Number: 18588 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Jun 2022 00:50:11 +0000 Gerrit-HasComments: Yes
