[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18549 )
Change subject: IMPALA-1682: Support printing the output of a query (rows) vertically. ...................................................................... Patch Set 10: (4 comments) > Patch Set 8: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/18549/5/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/18549/5/shell/shell_output.py@108 PS5, Line 108: val.encode('utf-8', 'replace') if isinstance(val, unicode) else val > Sorry that I think we can leave it as-is, because using utf8_encode_if_need Done http://gerrit.cloudera.org:8080/#/c/18549/5/shell/shell_output.py@110 PS5, Line 110: ************************************** > Sure. Thanks for sharing the MySQL codes. Done http://gerrit.cloudera.org:8080/#/c/18549/7/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/18549/7/shell/shell_output.py@85 PS7, Line 85: if sys.version_info.major == 2: > Python3 doesn't have 'unicode' type. We should still check sys.version_info Oh my mistake, thanks. http://gerrit.cloudera.org:8080/#/c/18549/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/18549/5/tests/shell/test_shell_commandline.py@295 PS5, Line 295: select 1 as > I see you use c1, c2, c3 as the column names. I tend to names in different OK, 'first' is keyword, so I use 'col_xxx' instead. -- To view, visit http://gerrit.cloudera.org:8080/18549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cee48d5a239d6b7c0f51331275524a25130fadf Gerrit-Change-Number: 18549 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 07 Jun 2022 13:21:23 +0000 Gerrit-HasComments: Yes
