Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18602 )
Change subject: IMPALA-9615: re2's max_mem opt configurable via an Impala startup flag ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18602/3/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18602/3/be/src/exprs/string-functions-ir.cc@944 PS3, Line 944: // Substitute("Invalid mem limit for re2's regex engine: $0", FLAGS_re2_mem_limit)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18602/3/tests/custom_cluster/test_re2_max_mem.py File tests/custom_cluster/test_re2_max_mem.py: http://gerrit.cloudera.org:8080/#/c/18602/3/tests/custom_cluster/test_re2_max_mem.py@42 PS3, Line 42: i flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/18602/3/tests/custom_cluster/test_re2_max_mem.py@44 PS3, Line 44: / flake8: E501 line too long (110 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/18602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf28d2f7217b1322ab8fdfb2c02fff0608078571 Gerrit-Change-Number: 18602 Gerrit-PatchSet: 3 Gerrit-Owner: Omid Shahidi <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 09 Jun 2022 20:28:00 +0000 Gerrit-HasComments: Yes
