Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18625 )
Change subject: IMPALA-11337: Flush row output before writing "Fetched X row(s)" ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18625/2/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/18625/2/tests/shell/util.py@231 PS2, Line 231: if wait_until_connected and not quiet_in_args and not stdout_stderr_redirected: > This logic doesn't seem quite right. We look for "Connected to" in stderr, Good point, simplified this to only use stderr_file. -- To view, visit http://gerrit.cloudera.org:8080/18625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83f89c110fd90d2d54331c7121e407d9de99146c Gerrit-Change-Number: 18625 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 14 Jun 2022 21:48:32 +0000 Gerrit-HasComments: Yes
