Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )
Change subject: IMPALA-11358: Fixed Kudu table's missing comment ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18627/5/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18627/5/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@259 PS5, Line 259: if(params.getComment() != null) : tableOpts.setComment(params.getComment()); nit: in Impala we add braces if we have to break the line after if -- To view, visit http://gerrit.cloudera.org:8080/18627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55 Gerrit-Change-Number: 18627 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jun 2022 06:21:20 +0000 Gerrit-HasComments: Yes
