Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 )
Change subject: IMPALA-11367: There should be LINE_DELIM above '# Partition Transform Information' ...................................................................... Patch Set 1: (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/18634/1/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java: http://gerrit.cloudera.org:8080/#/c/18634/1/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@112 PS1, Line 112: formatColumnsHeader(info, null); Also in the columns header we should see # col_name transform_type NULL https://github.com/apache/hive/blob/01b8fcffcb31cc128e71350d1b25c98b50ee85e5/iceberg/iceberg-handler/src/test/results/positive/describe_iceberg_table.q.out#L107 But we currently see: # col_name data_type comment -- To view, visit http://gerrit.cloudera.org:8080/18634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I991644cefb34decc843a5542b47eaec11d7b6e42 Gerrit-Change-Number: 18634 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jun 2022 12:13:42 +0000 Gerrit-HasComments: Yes
