Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18635 )
Change subject: IMPALA-886: Support displaying HBase cols in the order from HMS ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/18635/2/be/src/exec/hbase-scan-node.cc File be/src/exec/hbase-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/18635/2/be/src/exec/hbase-scan-node.cc@101 PS2, Line 101: return cola.family == colb.family ? cola.qualifier < colb.qualifier : cola.family < colb.family; line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/18635/2/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/18635/2/testdata/bin/generate-schema-statements.py@478 PS2, Line 478: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/18635/2/testdata/bin/generate-schema-statements.py@794 PS2, Line 794: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/18635/2/tests/custom_cluster/test_hbase_hms_column_order.py File tests/custom_cluster/test_hbase_hms_column_order.py: http://gerrit.cloudera.org:8080/#/c/18635/2/tests/custom_cluster/test_hbase_hms_column_order.py@20 PS2, Line 20: import os flake8: F401 'os' imported but unused http://gerrit.cloudera.org:8080/#/c/18635/2/tests/custom_cluster/test_hbase_hms_column_order.py@21 PS2, Line 21: import pytest flake8: F401 'pytest' imported but unused http://gerrit.cloudera.org:8080/#/c/18635/2/tests/custom_cluster/test_hbase_hms_column_order.py@22 PS2, Line 22: from subprocess import check_call flake8: F401 'subprocess.check_call' imported but unused http://gerrit.cloudera.org:8080/#/c/18635/2/tests/custom_cluster/test_hbase_hms_column_order.py@25 PS2, Line 25: from tests.common.file_utils import create_table_from_parquet flake8: F401 'tests.common.file_utils.create_table_from_parquet' imported but unused http://gerrit.cloudera.org:8080/#/c/18635/2/tests/custom_cluster/test_hbase_hms_column_order.py@26 PS2, Line 26: from tests.util.filesystem_utils import get_fs_path flake8: F401 'tests.util.filesystem_utils.get_fs_path' imported but unused http://gerrit.cloudera.org:8080/#/c/18635/2/tests/custom_cluster/test_hbase_hms_column_order.py@28 PS2, Line 28: class TestHBaseHmsColumnOrder(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/18635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc5df8b803f2ae3b93951765326cdaea706e3563 Gerrit-Change-Number: 18635 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 17 Jun 2022 15:53:28 +0000 Gerrit-HasComments: Yes
