Yu-Wen Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18626 )
Change subject: IMPALA-9670: Fix unloaded views are shown as tables for GET_TABLES requests ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Thank you for helping me understand the context! http://gerrit.cloudera.org:8080/#/c/18626/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/18626/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1903 PS3, Line 1903: String tableName = tblMeta.getTableName().toLowerCase(); > Yeah, we can save the other toLowerCase() calls. As mentioned in our doc: Ack http://gerrit.cloudera.org:8080/#/c/18626/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/18626/3/tests/common/impala_test_suite.py@119 PS3, Line 119: IMPALAD_HOSTNAME_LIST[i] + ':' + > We calculate the hs2 ports and hs2-http ports based on the specified beeswa Ack -- To view, visit http://gerrit.cloudera.org:8080/18626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I528bb20272ebdd66a0118c30efc2b0566f2b0e2f Gerrit-Change-Number: 18626 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Mon, 20 Jun 2022 03:03:20 +0000 Gerrit-HasComments: Yes
