Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18636 )
Change subject: IMPALA-11369: Separate thrift compiler for different component ...................................................................... Patch Set 4: (1 comment) This is looking good to me. I had one small comment. http://gerrit.cloudera.org:8080/#/c/18636/4/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18636/4/common/thrift/CMakeLists.txt@131 PS4, Line 131: set(THRIFT_INCLUDE_DIR_OPTION -I ${THRIFT_CPP_CONTRIB_DIR} -I $ENV{HIVE_METASTORE_THRIFT_DIR} : -I ${HIVE_THRIFT_SOURCE_DIR}) This is used for all three languages (see CPP_ARGS, JAVA_FE_ARGS, JAVA_EXT_DS_ARGS, PYTHON_ARGS, etc). We'll need to split it out for the different languages, so let's go ahead and do that. -- To view, visit http://gerrit.cloudera.org:8080/18636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56479dc69b79024d1a4d09211bbe88a61fa0c6a4 Gerrit-Change-Number: 18636 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 20 Jun 2022 21:15:23 +0000 Gerrit-HasComments: Yes
