Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18649 )
Change subject: IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases ...................................................................... Patch Set 1: (2 comments) Thanks for fixing this. Looks great, only had small comments. http://gerrit.cloudera.org:8080/#/c/18649/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/18649/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@647 PS1, Line 647: destination nit: target table http://gerrit.cloudera.org:8080/#/c/18649/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-overwrite.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-overwrite.test: http://gerrit.cloudera.org:8080/#/c/18649/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-overwrite.test@177 PS1, Line 177: insert overwrite iceberg_overwrite_bucket values (1), (2), (3); This could be 3 different INSERTs, then we could also check SELECT INPUT__FILE__NAME, count(*) FROM t; It should show 3 different files. And after INSERT OVERWRITE the same query would show a single file. -- To view, visit http://gerrit.cloudera.org:8080/18649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1bc19d839297246eadeb754cdeeec1e306098a Gerrit-Change-Number: 18649 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 11:25:33 +0000 Gerrit-HasComments: Yes
