Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18657 )
Change subject: IMPALA-11383: Add Thrift 0.13.0, 0.14.2, and 0.16.0 ...................................................................... IMPALA-11383: Add Thrift 0.13.0, 0.14.2, and 0.16.0 This adds newer Thrift versions to address open CVEs. Since upstream Impala now supports using different versions of Thrift for different languages, this includes multiple versions to allow flexibility. Thrift 0.14.2 and 0.16.0 are suitable for any language. Thrift 0.13.0 is not suitable for C++, because it does not support overriding certain Thread methods that Impala uses. The newer version includes some patches that were already on Thrift 0.11. The one new patch is a fix for a SIGSEGV in Thrift's Thread destructor when the Thread is uninitialized. This also stops building the C++ fb303 code and instead packages the fb303 thrift file. The fb303 library is not used by Impala's build and the C++ build for it is no longer reliably maintained. This moves Thrift 0.9.0 and 0.9.3 to BUILD_HISTORICAL as they are no longer in use. Testing: - Ran full build Change-Id: Ida147367c007dff3458508a477f7f6684305fb32 Reviewed-on: http://gerrit.cloudera.org:8080/18657 Reviewed-by: Riza Suminto <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M buildall.sh M source/thrift/build.sh A source/thrift/thrift-0.13.0-patches/0001-TLS-forward-compatibility.patch A source/thrift/thrift-0.13.0-patches/0002-THRIFT-2087-Python-compiler-replace-non-utf-8-char-w.patch A source/thrift/thrift-0.13.0-patches/0003-THRIFT-5303-Fix-missing-error-handling-in-using-PyUn.patch A source/thrift/thrift-0.13.0-patches/0004-IMPALA-11195-Disable-SSL-renegotiations.patch A source/thrift/thrift-0.14.2-patches/0001-TLS-forward-compatibility.patch A source/thrift/thrift-0.14.2-patches/0002-IMPALA-11195-Disable-SSL-renegotiations.patch A source/thrift/thrift-0.14.2-patches/0003-THRIFT-5418-Fix-missing-implementation-for-enum-func.patch A source/thrift/thrift-0.14.2-patches/0004-Fix-Thread-destructor-sigsegv-when-uninitialized.patch A source/thrift/thrift-0.16.0-patches/0001-TLS-forward-compatibility.patch A source/thrift/thrift-0.16.0-patches/0002-IMPALA-11195-Disable-SSL-renegotiations.patch A source/thrift/thrift-0.16.0-patches/0003-Fix-Thread-destructor-sigsegv-when-uninitialized.patch 13 files changed, 456 insertions(+), 5 deletions(-) Approvals: Riza Suminto: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/18657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ida147367c007dff3458508a477f7f6684305fb32 Gerrit-Change-Number: 18657 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
