Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18668 )
Change subject: [tools] Download shell dependencies from PyPI ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/find_py26.py File shell/packaging/find_py26.py: http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/find_py26.py@27 PS1, Line 27: import sys flake8: F401 'sys' imported but unused http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/find_py26.py@30 PS1, Line 30: def detect_python_cmd(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/pip_download.py File shell/packaging/pip_download.py: http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/pip_download.py@78 PS1, Line 78: def get_package_info(pkg_name, pkg_version): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/pip_download.py@101 PS1, Line 101: f flake8: E129 visually indented line with same indent as next logical line http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/pip_download.py@108 PS1, Line 108: @retry flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/pip_download.py@128 PS1, Line 128: def main(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/pip_download.py@148 PS1, Line 148: l flake8: E741 ambiguous variable name 'l' http://gerrit.cloudera.org:8080/#/c/18668/1/shell/packaging/pip_download.py@158 PS1, Line 158: if __name__ == '__main__': flake8: E305 expected 2 blank lines after class or function definition, found 1 -- To view, visit http://gerrit.cloudera.org:8080/18668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b76e112ba9d0db19fae3e8eb15fd54a721f80fd Gerrit-Change-Number: 18668 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 24 Jun 2022 16:12:12 +0000 Gerrit-HasComments: Yes
