Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18661 )
Change subject: IMPALA-11384: Upgrade CPP thrift components to thrift-0.16.0 ...................................................................... IMPALA-11384: Upgrade CPP thrift components to thrift-0.16.0 This patch upgrades IMPALA_THRIFT_CPP_VERSION=0.16.0-p3 to mitigate CVE-2020-13949 and hang issue with newer JDBC client. IMPALA_TOOLCHAIN_BUILD_ID is upgraded to 179-9977806f06, which contains the required thrift-0.16.0 compiler. The refactoring itself includes: - Removing non-generated (empty) *_constants.cpp and adjustment for THRIFT-4730. - Adjusts error handling in client-request-state.cc due to changing thrift error message after the upgrade. - Adding custom build target thrift-cpp-manual-edit to fix clang-diagnostic-inconsistent-missing-override warning in generated ImpalaHiveServer2Service.h and ImpalaService.h Testing: - Build and pass core tests. Change-Id: Ic278ac5c973ff5c3e829a6139b9c16e9d2c62a59 Reviewed-on: http://gerrit.cloudera.org:8080/18661 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/rpc/TAcceptQueueServer.cpp M be/src/rpc/TAcceptQueueServer.h M be/src/rpc/thrift-thread.cc M be/src/rpc/thrift-thread.h M be/src/rpc/thrift-util.cc M be/src/runtime/io/disk-io-mgr.cc M be/src/service/client-request-state.cc M be/src/transport/THttpTransport.cpp M be/src/transport/THttpTransport.h M be/src/transport/TSaslTransport.cpp M be/src/transport/TSaslTransport.h M be/src/util/process-state-info.cc M bin/impala-config.sh M common/thrift/CMakeLists.txt 15 files changed, 38 insertions(+), 60 deletions(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic278ac5c973ff5c3e829a6139b9c16e9d2c62a59 Gerrit-Change-Number: 18661 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
