Laszlo Gaal (Cloudera) has uploaded this change for review. (
http://gerrit.cloudera.org:8080/18678
Change subject: IMPALA-11403: Fix cmake escaping for sed regex in common/thrift
......................................................................
IMPALA-11403: Fix cmake escaping for sed regex in common/thrift
common/thrift/CMakeLists.txt contains a sed command line with a captured
group. This sed construct uses a single backslash ('\1'), which was
entered verbatim into CMakeLists.txt. The backslash character is however
an escape character for cmake as well, so it reported a warning about
incorrect escaping syntax when processing this file.
Fortunately the generated Makefile output was still correct.
The patch doubles the backslashes in the sed command line to escape them
correctly according to cmake's syntax rules.
Tested by running `./buildall.sh -cmake_only` on the changed file and
verifying that
- the warning is eliminated
- the generated output still contained the expected sed regex.
Change-Id: I8785fa0500d3a296f98efb973c6ce0737a02e8bb
---
M common/thrift/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/18678/1
--
To view, visit http://gerrit.cloudera.org:8080/18678
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8785fa0500d3a296f98efb973c6ce0737a02e8bb
Gerrit-Change-Number: 18678
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal (Cloudera) <[email protected]>
