[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )
Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift@514 PS4, Line 514: ameters > I think this sholud be optional as we haven't use this field earlier. Done http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift@516 PS4, Line 516: // Fully qualified name of the table to create : 1: required CatalogObjects.TTableName table_name : : // List of columns to create : 2: required list<CatalogObjects.TColumn> columns > Can't we retrieve this information at the Catalog side from the source tabl Done http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@215 PS4, Line 215: > It's better to use FeIcebergTable, because if local catalog mode is used th Done http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@194 PS4, Line 194: > nit: or partitionFields.empty() ? Done -- To view, visit http://gerrit.cloudera.org:8080/18658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac Gerrit-Change-Number: 18658 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 05 Jul 2022 11:37:18 +0000 Gerrit-HasComments: Yes
