Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to 
be read
......................................................................


Patch Set 16:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/16/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18652/16/tests/query_test/test_scanners.py@1785
PS16, Line 1785: stored as iceberg stored as orc
I don't think this is the right syntax. You can run the test locally by

 impala-py.test 
tests/query_test/test_scanners.py::TestOrc::test_missing_field_orc

Refer to https://impala.apache.org/docs/build/html/topics/impala_iceberg.html
The statement should be something like

 create table ice_orc (f0 int) stored as iceberg 
tblproperties('write.format.default' = 'orc');



--
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: ttttttz <[email protected]>
Gerrit-Comment-Date: Wed, 06 Jul 2022 10:10:25 +0000
Gerrit-HasComments: Yes

Reply via email to