Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18705 )
Change subject: IMPALA-11417: Support outer join elimination optimization ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18705/2/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/18705/2/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@145 PS2, Line 145: public boolean isOnlyInJoinConds() { return isOnlyInJoinConds_ == null ? true : isOnlyInJoinConds_; } line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/18705/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/18705/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2030 PS2, Line 2030: boolean canEliminate = canEliminateInnerPlan(analyzer, inner, innerRef, eqJoinConjuncts); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18705/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2105 PS2, Line 2105: private boolean canEliminateInnerPlan(Analyzer analyzer, PlanNode innerPlan, TableRef innerRef, List<BinaryPredicate> eqJoinConjuncts) { line too long (139 > 90) http://gerrit.cloudera.org:8080/#/c/18705/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2132 PS2, Line 2132: List<SQLPrimaryKey> pks = innerRef.getResolvedPath().destTable().getSqlConstraints().getPrimaryKeys(); line too long (106 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2e68263a029ac84a4f35b0846b22aa42d7ceece Gerrit-Change-Number: 18705 Gerrit-PatchSet: 2 Gerrit-Owner: Jian Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 07 Jul 2022 02:52:43 +0000 Gerrit-HasComments: Yes
