Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18635 )
Change subject: IMPALA-886: Support displaying HBase cols in the order from HMS ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/18635/4/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/18635/4/be/src/util/backend-gflag-util.cc@189 PS4, Line 189: DEFINE_bool(use_hms_column_order_for_hbase_tables, false, > nit: duplicated blank line Done http://gerrit.cloudera.org:8080/#/c/18635/4/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/18635/4/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@136 PS4, Line 136: columns.get(i); > nit: use 'columns' directly Done http://gerrit.cloudera.org:8080/#/c/18635/4/testdata/workloads/functional-query/queries/QueryTest/hbase-hms-column-order.test File testdata/workloads/functional-query/queries/QueryTest/hbase-hms-column-order.test: http://gerrit.cloudera.org:8080/#/c/18635/4/testdata/workloads/functional-query/queries/QueryTest/hbase-hms-column-order.test@5 PS4, Line 5: = > nit: needs a space after '=' Done http://gerrit.cloudera.org:8080/#/c/18635/4/testdata/workloads/functional-query/queries/QueryTest/hbase-hms-column-order.test@31 PS4, Line 31: ==== > It'd be nice if we can copy some tests from testdata/workloads/functional-p Added a test with predicate on string key and checked the result + that the predicate is pushed down to the plan. -- To view, visit http://gerrit.cloudera.org:8080/18635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc5df8b803f2ae3b93951765326cdaea706e3563 Gerrit-Change-Number: 18635 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 13 Jul 2022 16:14:49 +0000 Gerrit-HasComments: Yes
