Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables This commit implements cloning between Kudu tables. Cloing Kudu tables from other types of tables is not implemented, because the table creation statement is not completely consistent. ...................................................................... Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@217 PS1, Line 217: private void ensureCreateKuduTableParamsValid(FeTable srcTable) throws AnalysisException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@219 PS1, Line 219: if ((fileFormat_ == THdfsFileFormat.KUDU && !KuduTable.isKuduTable(srcTable.getMetaStoreTable())) || (fileFormat_ != null && fileFormat_ != THdfsFileFormat.KUDU && KuduTable.isKuduTable(srcTable.getMetaStoreTable()))) { line too long (223 > 90) http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@221 PS1, Line 221: throw new AnalysisException(srcTable.getFullName() + " cannot be cloned because SORT BY is not supported for Kudu tables."); line too long (132 > 90) http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@227 PS1, Line 227: throw new AnalysisException(srcTable.getFullName() + " cannot be cloned because it cannot be cloned into a " + targeTableFileFormat.toString() + " table."); line too long (162 > 90) http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3776 PS1, Line 3776: TCreateTableParams createTableParams = extractCreateTableParams(params, tblName, (KuduTable)srcTable, tbl); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3787 PS1, Line 3787: private TCreateTableParams extractCreateTableParams(TCreateTableLikeParams params, TableName tblName, KuduTable kuduTable, line too long (124 > 90) http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3801 PS1, Line 3801: throw new UnsupportedOperationException("CREATE TABLE LIKE is not supported for Kudu tables hava range partition."); line too long (124 > 90) http://gerrit.cloudera.org:8080/#/c/18729/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3809 PS1, Line 3809: tableProperties.put(KuduTable.KEY_TABLE_NAME, String.format("%s::%s:%s", params.getOwner(), tblName.getDb(), tblName.getTbl())); line too long (132 > 90) http://gerrit.cloudera.org:8080/#/c/18729/1/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/18729/1/tests/query_test/test_kudu.py@92 PS1, Line 92: a flake8: E501 line too long (96 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 14 Jul 2022 03:36:23 +0000 Gerrit-HasComments: Yes
