Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18676 )
Change subject: IMPALA-11430: Support custom hash schema for Kudu range tables ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/18676/10/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/18676/10/fe/src/main/cup/sql-parser.cup@1760 PS10, Line 1760: {: RESULT = Lists.newArrayList(dc); :} > What's 'dc' in this context? That was a mistake in last minute change that I added. This production should not fire for positive cases with %prec on the clause above but this was added a defensive measure since an NPE could occur if the production is used. http://gerrit.cloudera.org:8080/#/c/18676/10/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18676/10/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@229 PS10, Line 229: getRangePartitionWithCustomHashSchema(rangePartition, rangeBounds); > nit: Indentation would help readability here. Done -- To view, visit http://gerrit.cloudera.org:8080/18676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I981056e0827f4957580706d6e73742e4e6743c1c Gerrit-Change-Number: 18676 Gerrit-PatchSet: 10 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 14 Jul 2022 18:47:47 +0000 Gerrit-HasComments: Yes
