Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18734 )
Change subject: IMPALA-11434: Fix analysis of multiple more than 1d arrays in select list ...................................................................... Patch Set 2: Code-Review+1 (2 comments) The change makes sense to me. I just have 2 nits. http://gerrit.cloudera.org:8080/#/c/18734/2/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/18734/2/testdata/datasets/functional/functional_schema_template.sql@3481 PS2, Line 3481: id INT : int_1d ARRAY<INT> : string_1d ARRAY<STRING> : int_2d ARRAY<ARRAY<INT>> : string_2d ARRAY<ARRAY<STRING>> : int_3d ARRAY<ARRAY<ARRAY<INT>>> : string_3d ARRAY<ARRAY<ARRAY<STRING>>> nit: for better readability and match order in nested-array-in-select-list.test, maybe reorder the columns based on data type then nesting level. so: id INT int_1d ARRAY<INT> int_2d ARRAY<ARRAY<INT>> int_3d ARRAY<ARRAY<ARRAY<INT>>> string_1d ARRAY<STRING> string_2d ARRAY<ARRAY<STRING>> string_3d ARRAY<ARRAY<ARRAY<STRING>>> http://gerrit.cloudera.org:8080/#/c/18734/2/testdata/datasets/functional/functional_schema_template.sql@3491 PS2, Line 3491: array(1, 2, NULL), array("1", "2", NULL), nit: consider 1 row for each complex entry for better readability. -- To view, visit http://gerrit.cloudera.org:8080/18734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f2b6cad51fa25a6f6932420eccf1b0a964d5e4e Gerrit-Change-Number: 18734 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 14 Jul 2022 20:13:34 +0000 Gerrit-HasComments: Yes
