Csaba Ringhofer has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/18610 )

Change subject: IMPALA-10267: Properly handle continued scanning after parse 
error in HdfsAvroScanner
......................................................................

IMPALA-10267: Properly handle continued scanning after parse error in 
HdfsAvroScanner

BaseSequenceScanner assumes that overloads of ProcessRange can continue
working after a parse error (some bytes can be skipped in this case
until the next sync marker) but HdfsAvroScanner::ProcessRange() did not
handle this scenario.

Testing:
- ran core tests
- didn't create new tests - the test was caught by a fuzz test,
  it would be great to check whether we actually handle this
  scenario, but I am not that familiar with Avro

Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Reviewed-on: http://gerrit.cloudera.org:8080/18610
Reviewed-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Csaba Ringhofer <[email protected]>
---
M be/src/exec/hdfs-avro-scanner.cc
1 file changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Csaba Ringhofer: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>

Reply via email to