Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18731 )
Change subject: IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE ...................................................................... Patch Set 5: (16 comments) http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java File fe/src/main/java/org/apache/impala/planner/HashJoinNode.java: http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@139 PS5, Line 139: if (this.getJoinOp().isLeftOuterJoin() || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@140 PS5, Line 140: this.getJoinOp().isRightOuterJoin() || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@350 PS5, Line 350: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@376 PS5, Line 376: if (this.joinOp_ == JoinOperator.LEFT_OUTER_JOIN || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@380 PS5, Line 380: if (this.joinOp_ == JoinOperator.RIGHT_OUTER_JOIN || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@386 PS5, Line 386: private void pushdownNonEquiConjunct(Analyzer analyzer, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@387 PS5, Line 387: List<Expr> assignedConjunctsExprs, int buildIndex, int probeIndex) throws ImpalaException { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@422 PS5, Line 422: pushOtherJoinBinaryPredicateToChild((BinaryPredicate) nonEquiPredicate, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@581 PS5, Line 581: // The key is build table's expr, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@592 PS5, Line 592: if (!(predicate.getChild(0) instanceof LiteralExpr line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@594 PS5, Line 594: && !(predicate.getChild(1) instanceof LiteralExpr line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@612 PS5, Line 612: List<Predicate> predicateList = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@655 PS5, Line 655: List<Predicate> predicateList = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@854 PS5, Line 854: // so, predicate can be simplified to: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/18731/5/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2023 PS5, Line 2023: boolean enableJoinPushdown = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18731/5/tests/query_test/test_none_equi_predicate_pushdown.py File tests/query_test/test_none_equi_predicate_pushdown.py: http://gerrit.cloudera.org:8080/#/c/18731/5/tests/query_test/test_none_equi_predicate_pushdown.py@33 PS5, Line 33: c flake8: E501 line too long (99 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/18731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ce23cbd7522a209c830504f329b972d67bc263 Gerrit-Change-Number: 18731 Gerrit-PatchSet: 5 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Jul 2022 16:38:08 +0000 Gerrit-HasComments: Yes
