Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18736 )
Change subject: IMPALA-10918: Allow map type in SELECT list ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/18736/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/18736/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@494 PS2, Line 494: if (!mapType.getKeyType().isSupported() || !mapType.getValueType().isSupported()) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/18736/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/18736/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@722 PS2, Line 722: // authorize("select int_map_col, array_map_col, map_map_col from functional.allcomplextypes") line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/18736/2/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@724 PS2, Line 724: authorize("select int_map_col, array_map_col, map_map_col from functional.allcomplextypes") line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18736/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/18736/2/tests/authorization/test_ranger.py@1790 PS2, Line 1790: # flake8: E266 too many leading '#' for block comment http://gerrit.cloudera.org:8080/#/c/18736/2/tests/authorization/test_ranger.py@1792 PS2, Line 1792: u flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/18736/2/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/18736/2/tests/query_test/test_nested_types.py@205 PS2, Line 205: I flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/18736/2/tests/query_test/test_nested_types.py@207 PS2, Line 207: c flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/18736/2/tests/query_test/test_nested_types.py@208 PS2, Line 208: ' flake8: E126 continuation line over-indented for hanging indent -- To view, visit http://gerrit.cloudera.org:8080/18736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I921c647f1779add36e7f5df4ce6ca237dcfaf001 Gerrit-Change-Number: 18736 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 20 Jul 2022 11:22:26 +0000 Gerrit-HasComments: Yes
