Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 4: (1 comment) Thanks for working on this feature! http://gerrit.cloudera.org:8080/#/c/18729/4/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test: http://gerrit.cloudera.org:8080/#/c/18729/4/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test@4 PS4, Line 4: create table kudu_alltypes_clone like functional_kudu.alltypes Can we add a negative test for cloning from a partitioned table of other types, e.g. functional.alltypes? We can use the "---- CATCH" section to catch expected failures. I think we also need tests on cases when Kudu-HMS integration is enabled/disabled. -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 20 Jul 2022 14:05:34 +0000 Gerrit-HasComments: Yes
