Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18759 )

Change subject: IMPALA-11445: Allow partitions located in different file systems
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18759/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18759/1//COMMIT_MSG@7
PS1, Line 7: Allow partitions located in different file systems
> I think we already allow this but we have bug in firing insert events. Can
Done


http://gerrit.cloudera.org:8080/#/c/18759/1/testdata/workloads/functional-query/queries/QueryTest/partition-location.test
File 
testdata/workloads/functional-query/queries/QueryTest/partition-location.test:

http://gerrit.cloudera.org:8080/#/c/18759/1/testdata/workloads/functional-query/queries/QueryTest/partition-location.test@72
PS1, Line 72: hdfs://localhost:20500
> Can we run the test on S3 if we replace this to $FILESYSTEM_PREFIX?
Changed to $FILESYSTEM_PREFIX and ran the test on s3


http://gerrit.cloudera.org:8080/#/c/18759/1/tests/query_test/test_partitioning.py
File tests/query_test/test_partitioning.py:

http://gerrit.cloudera.org:8080/#/c/18759/1/tests/query_test/test_partitioning.py@100
PS1, Line 100:   @SkipIfS3.hive
             :   @SkipIfGCS.hive
             :   @SkipIfCOS.hive
             :   @SkipIfABFS.hive
             :   @SkipIfADLS.hive
> It'd be nice if we can test this on object storages. Let's see if using $FI
Changed to $FILESYSTEM_PREFIX and could run the test on s3.



--
To view, visit http://gerrit.cloudera.org:8080/18759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0491ee1bf40c3d5240f9124cef3f3169c44a8267
Gerrit-Change-Number: 18759
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Wed, 20 Jul 2022 22:20:21 +0000
Gerrit-HasComments: Yes

Reply via email to