Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18759 )

Change subject: IMPALA-11445: Fix bug in firing insert event of partitions 
located in different FS
......................................................................


Patch Set 7:

(1 comment)

> Patch Set 7:
>
> The new test use local file system for partition locations. But verification 
> job create impala mini-cluster with calatogd, statestored and impalad running 
> on different containers. This cause calatogd could not access the data files 
> generated by impalad.
> Switch to local-catalog mode for the new test.

Nice finding! Let's move this to the custom cluster test and add the coverage 
on both catalog modes.

http://gerrit.cloudera.org:8080/#/c/18759/6/tests/custom_cluster/test_partition.py
File tests/custom_cluster/test_partition.py:

http://gerrit.cloudera.org:8080/#/c/18759/6/tests/custom_cluster/test_partition.py@52
PS6, Line 52:
We also need to test this on legacy catalog mode, i.e.

  @CustomClusterTestSuite.with_args(
    impalad_args="--use_local_catalog=false",
    catalogd_args="--catalog_topic_mode=full")



--
To view, visit http://gerrit.cloudera.org:8080/18759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0491ee1bf40c3d5240f9124cef3f3169c44a8267
Gerrit-Change-Number: 18759
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Thu, 21 Jul 2022 22:54:17 +0000
Gerrit-HasComments: Yes

Reply via email to