Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18760 )
Change subject: IMPALA-11446: Push-down NOT_IN predicate to iceberg ...................................................................... Patch Set 2: Thanks for working on this! I think it is great to push down the 'not in' predicate for partition columns, however for non-partition columns I believe it would be better to throw an AnalysisException. Otherwise the user won’t know that the specified predicate skips columns in the background. -- To view, visit http://gerrit.cloudera.org:8080/18760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8bdaf6f31a4438e11c4eb27485bb413fe6df9a3 Gerrit-Change-Number: 18760 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Fri, 22 Jul 2022 08:54:55 +0000 Gerrit-HasComments: No
