Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18734 )
Change subject: IMPALA-11434: Fix analysis of multiple more than 1d arrays in select list ...................................................................... IMPALA-11434: Fix analysis of multiple more than 1d arrays in select list More than 1d arrays in select list tried to register a CollectionTableRef with name "item" for the inner arrays, leading to name collision if there was more than one such array. The logic is changed to always use the full path as implicit alias in CollectionTableRefs backing arrays in select list. As a side effect this leads to using the fully qualified names in expressions in the explain plans of queries that use arrays from views. This is not an intended change, but I don't consider it to be critical. Created IMPALA-11452 to deal with more sophisticated alias handling in collections. Testing: - added a new table to testdata and a regression test Change-Id: I6f2b6cad51fa25a6f6932420eccf1b0a964d5e4e Reviewed-on: http://gerrit.cloudera.org:8080/18734 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java M fe/src/main/java/org/apache/impala/analysis/FromClause.java M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java M fe/src/main/java/org/apache/impala/catalog/Type.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M testdata/datasets/functional/functional_schema_template.sql M testdata/datasets/functional/schema_constraints.csv M testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test M testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test 10 files changed, 65 insertions(+), 26 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6f2b6cad51fa25a6f6932420eccf1b0a964d5e4e Gerrit-Change-Number: 18734 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
