Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18740 )
Change subject: IMPALA-11439: Add option to control whether prepopulate m2 directory or not. ...................................................................... Patch Set 2: > Patch Set 2: > > Your concern is valid, and the implementation looks fine. > However, I do have some concern about changing the default behavior of the > build, when the environment variable is absent. My reading of the change is that the default behavior doesn't change. If the variable's unset, it defaults to PREPOPULATE_M2_REPOSITORY=true. -- To view, visit http://gerrit.cloudera.org:8080/18740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ac55099f326e2abe2f7dc66c08ad7023cb6baf Gerrit-Change-Number: 18740 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal (Cloudera) <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 25 Jul 2022 15:54:45 +0000 Gerrit-HasComments: No
