Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18781 )
Change subject: IMPALA-11456: Collapse filesystem Skip logic to SkipIfFS ...................................................................... Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/18781/1/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/common/skip.py@44 PS1, Line 44: class SkipIfFS: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/custom_cluster/test_admission_controller.py@39 PS1, Line 39: S flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/18781/1/tests/custom_cluster/test_insert_behaviour.py File tests/custom_cluster/test_insert_behaviour.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/custom_cluster/test_insert_behaviour.py@30 PS1, Line 30: @SkipIfFS.hdfs_acls flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/custom_cluster/test_metadata_replicas.py File tests/custom_cluster/test_metadata_replicas.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/custom_cluster/test_metadata_replicas.py@23 PS1, Line 23: @SkipIfFS.hive flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/custom_cluster/test_permanent_udfs.py@180 PS1, Line 180: @ flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/18781/1/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/data_errors/test_data_errors.py@107 PS1, Line 107: @SkipIfFS.qualified_path flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/data_errors/test_data_errors.py@124 PS1, Line 124: @SkipIfFS.qualified_path flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/failure/test_failpoints.py File tests/failure/test_failpoints.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/failure/test_failpoints.py@62 PS1, Line 62: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/18781/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/metadata/test_hms_integration.py@146 PS1, Line 146: @SkipIfFS.hive flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/query_test/test_hdfs_caching.py@34 PS1, Line 34: @SkipIfFS.caching # missing coverage: verify SET CACHED gives error flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/query_test/test_hdfs_caching.py@34 PS1, Line 34: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/18781/1/tests/query_test/test_hdfs_caching.py@110 PS1, Line 110: @SkipIfFS.caching flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/query_test/test_insert_parquet.py@551 PS1, Line 551: @SkipIfFS.hive flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18781/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18781/1/tests/query_test/test_scanners.py@1376 PS1, Line 1376: @SkipIfFS.hive flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/18781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib928a6274baaaec45614887b9e762346a25812a1 Gerrit-Change-Number: 18781 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 25 Jul 2022 20:26:31 +0000 Gerrit-HasComments: Yes
